<html>
<head><meta charset="utf-8"><title>approving new targets · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html">approving new targets</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="201154228"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approving%20new%20targets/near/201154228" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html#201154228">(Jun 17 2020 at 15:04)</a>:</h4>
<p>Hey <span class="user-mention" data-user-id="116083">@pnkfelix</span> / <span class="user-mention" data-user-id="239881">@Josh Triplett</span> -- so <span class="user-mention" data-user-id="121055">@Pietro Albini</span> was asking me about compiler team process for approving new Tier 2 targets.</p>



<a name="201154268"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approving%20new%20targets/near/201154268" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html#201154268">(Jun 17 2020 at 15:04)</a>:</h4>
<p>i.e., we check that it builds, but don't run tests? Remind me <span class="user-mention" data-user-id="121055">@Pietro Albini</span> the precise details in this case...</p>



<a name="201154307"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approving%20new%20targets/near/201154307" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html#201154307">(Jun 17 2020 at 15:05)</a>:</h4>
<p>... in any case, I was thinking that probably an MCP suffices? I guess the question is how "reversible" the decision is</p>



<a name="201154333"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approving%20new%20targets/near/201154333" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html#201154333">(Jun 17 2020 at 15:05)</a>:</h4>
<p>The alternative is to require full FCP</p>



<a name="201154354"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approving%20new%20targets/near/201154354" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html#201154354">(Jun 17 2020 at 15:05)</a>:</h4>
<p>which strikes me as a good idea for Tier 1 but a bit overkill here? But I'm not sure.</p>



<a name="201154363"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approving%20new%20targets/near/201154363" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html#201154363">(Jun 17 2020 at 15:05)</a>:</h4>
<p>yeah, we produce full dist artifacts, but we don't run any test on them</p>



<a name="201154435"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approving%20new%20targets/near/201154435" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html#201154435">(Jun 17 2020 at 15:05)</a>:</h4>
<p>I guess the question hinges to some extent on how "committed" we are to continue doing that</p>



<a name="201154507"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approving%20new%20targets/near/201154507" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html#201154507">(Jun 17 2020 at 15:06)</a>:</h4>
<p>the problem with reversing the decision is that user won't be able to install it through rustup anymore</p>



<a name="201154540"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approving%20new%20targets/near/201154540" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html#201154540">(Jun 17 2020 at 15:06)</a>:</h4>
<p>Yeah. It's not trivially reversible</p>



<a name="201154557"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approving%20new%20targets/near/201154557" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html#201154557">(Jun 17 2020 at 15:06)</a>:</h4>
<p>and that will trickle down into stable</p>



<a name="201154571"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approving%20new%20targets/near/201154571" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html#201154571">(Jun 17 2020 at 15:06)</a>:</h4>
<p>Obviously we can decide to back out support but...</p>



<a name="201154598"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approving%20new%20targets/near/201154598" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html#201154598">(Jun 17 2020 at 15:06)</a>:</h4>
<p>it's not a good look</p>



<a name="201154601"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approving%20new%20targets/near/201154601" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html#201154601">(Jun 17 2020 at 15:06)</a>:</h4>
<p>...well that's always true :)</p>



<a name="201154633"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approving%20new%20targets/near/201154633" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html#201154633">(Jun 17 2020 at 15:06)</a>:</h4>
<p>I am now leaning towards a full FCP I guess</p>



<a name="201154641"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approving%20new%20targets/near/201154641" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html#201154641">(Jun 17 2020 at 15:06)</a>:</h4>
<p>probably t-compiler/t-infra</p>



<a name="201154686"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approving%20new%20targets/near/201154686" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html#201154686">(Jun 17 2020 at 15:07)</a>:</h4>
<p>well, we could enable the builder only on nightly</p>



<a name="201154733"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approving%20new%20targets/near/201154733" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html#201154733">(Jun 17 2020 at 15:07)</a>:</h4>
<p>I'm not aware of any target where we're doing it, but it's surely possible</p>



<a name="201154736"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approving%20new%20targets/near/201154736" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html#201154736">(Jun 17 2020 at 15:07)</a>:</h4>
<p>I'd definitely like us to kind of have a procedure here, this seems to be coming up more and more often.</p>



<a name="201154746"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approving%20new%20targets/near/201154746" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html#201154746">(Jun 17 2020 at 15:07)</a>:</h4>
<p>And to have a llist of criteria we'll use</p>



<a name="201154771"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approving%20new%20targets/near/201154771" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html#201154771">(Jun 17 2020 at 15:07)</a>:</h4>
<p>well there is that tier policy RFC :P</p>



<a name="201154776"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approving%20new%20targets/near/201154776" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html#201154776">(Jun 17 2020 at 15:07)</a>:</h4>
<p>I wll say that a "trial period" feels like a nice thing</p>



<a name="201154783"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approving%20new%20targets/near/201154783" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html#201154783">(Jun 17 2020 at 15:07)</a>:</h4>
<p>I know</p>



<a name="201154831"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approving%20new%20targets/near/201154831" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html#201154831">(Jun 17 2020 at 15:08)</a>:</h4>
<p>I guess I should review it decide how actionable it feels</p>



<a name="201154857"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approving%20new%20targets/near/201154857" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html#201154857">(Jun 17 2020 at 15:08)</a>:</h4>
<p>I'd like to be distilled somehow into a clear list of "stuff to consider"</p>



<a name="201154883"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approving%20new%20targets/near/201154883" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html#201154883">(Jun 17 2020 at 15:08)</a>:</h4>
<p>anyway I think we should go forward with the two cases under consideration</p>



<a name="201156776"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approving%20new%20targets/near/201156776" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pachi <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html#201156776">(Jun 17 2020 at 15:21)</a>:</h4>
<p>An interesting point of comparison may be debian ports (architectures) policy, and how they are supported. They have "published", "discontinued", "on development", "abandoned" and "replaced", and support is somehow linked to what we would call editions. I've only found this webpage, <a href="https://www.debian.org/ports/">https://www.debian.org/ports/</a> , but I'm sure a policy document must exist and could give some ideas.</p>



<a name="201163284"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approving%20new%20targets/near/201163284" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html#201163284">(Jun 17 2020 at 16:06)</a>:</h4>
<p>I proposed FCP for RISC-v <a href="https://github.com/rust-lang/compiler-team/issues/312#issuecomment-645467304">here</a> -- though, does rfcbot listen to the compiler-team repo?</p>



<a name="201163309"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approving%20new%20targets/near/201163309" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html#201163309">(Jun 17 2020 at 16:06)</a>:</h4>
<p>I really need to pick that up again. I'm on vacation from work, so this is probably a good time...</p>



<a name="201163324"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approving%20new%20targets/near/201163324" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html#201163324">(Jun 17 2020 at 16:06)</a>:</h4>
<p>cc <span class="user-mention" data-user-id="130111">@anp</span> <span aria-label="point up" class="emoji emoji-1f446" role="img" title="point up">:point_up:</span></p>



<a name="201164544"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approving%20new%20targets/near/201164544" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> anp <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html#201164544">(Jun 17 2020 at 16:16)</a>:</h4>
<p>it listens to all the rust-lang repos it can, but webhooks need to be configured on the github side to ping it for response times faster than the interval scraper</p>



<a name="201164579"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approving%20new%20targets/near/201164579" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> anp <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html#201164579">(Jun 17 2020 at 16:16)</a>:</h4>
<p>i thought we set that up at the org level but i can’t quite recall</p>



<a name="201167663"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approving%20new%20targets/near/201167663" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html#201167663">(Jun 17 2020 at 16:41)</a>:</h4>
<p>it worked now</p>



<a name="201167670"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approving%20new%20targets/near/201167670" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html#201167670">(Jun 17 2020 at 16:41)</a>:</h4>
<p>I was just impatient I guess ;)</p>



<a name="201173709"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approving%20new%20targets/near/201173709" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> anp <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html#201173709">(Jun 17 2020 at 17:27)</a>:</h4>
<p>a delay like that suggests a missing web hook config, should be easy enough to copy/paste from another repo</p>



<a name="201173812"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approving%20new%20targets/near/201173812" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> anp <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html#201173812">(Jun 17 2020 at 17:28)</a>:</h4>
<p><span class="user-mention" data-user-id="121055">@Pietro Albini</span> iirc at one point you audited all the webhooks, did that include moving rfcbot to an org we hook instead of repo ones?</p>



<a name="201255047"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approving%20new%20targets/near/201255047" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html#201255047">(Jun 18 2020 at 11:29)</a>:</h4>
<p>not yet</p>



<a name="201255051"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approving%20new%20targets/near/201255051" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html#201255051">(Jun 18 2020 at 11:29)</a>:</h4>
<p>it fell off my backlog a ton</p>



<a name="201325220"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approving%20new%20targets/near/201325220" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html#201325220">(Jun 18 2020 at 20:57)</a>:</h4>
<p>hmm <a href="https://github.com/rust-lang/compiler-team/issues/279#issuecomment-646049311">this rfcbot fcp</a> doesn't seem to have gotten started though</p>



<a name="201325273"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approving%20new%20targets/near/201325273" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html#201325273">(Jun 18 2020 at 20:58)</a>:</h4>
<p>cc <span class="user-mention" data-user-id="130111">@anp</span> <span class="user-mention" data-user-id="121055">@Pietro Albini</span> <span aria-label="point up" class="emoji emoji-1f446" role="img" title="point up">:point_up:</span> should I just try it again? :)</p>



<a name="201333049"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approving%20new%20targets/near/201333049" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html#201333049">(Jun 18 2020 at 22:25)</a>:</h4>
<p><span class="user-mention" data-user-id="116009">@nikomatsakis</span> I'll set a webhook tomorrow</p>



<a name="201343456"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approving%20new%20targets/near/201343456" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> anp <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html#201343456">(Jun 19 2020 at 01:06)</a>:</h4>
<p>looks like it went through: <a href="https://github.com/rust-lang/compiler-team/issues/312#issuecomment-645467720">https://github.com/rust-lang/compiler-team/issues/312#issuecomment-645467720</a></p>



<a name="201365255"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approving%20new%20targets/near/201365255" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html#201365255">(Jun 19 2020 at 08:44)</a>:</h4>
<p><em>let's go add the webhook</em> github is down lol</p>



<a name="201375147"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approving%20new%20targets/near/201375147" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html#201375147">(Jun 19 2020 at 10:51)</a>:</h4>
<p><span class="user-mention" data-user-id="130111">@anp</span> that first one did, but <a href="https://github.com/rust-lang/compiler-team/issues/279#issuecomment-646049311">this is a second one</a></p>



<a name="201418719"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approving%20new%20targets/near/201418719" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html#201418719">(Jun 19 2020 at 17:23)</a>:</h4>
<p><span class="user-mention" data-user-id="116009">@nikomatsakis</span> hmm, the webhook seems up</p>



<a name="201418735"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approving%20new%20targets/near/201418735" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html#201418735">(Jun 19 2020 at 17:23)</a>:</h4>
<p>and it has been up for a while</p>



<a name="201421382"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approving%20new%20targets/near/201421382" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html#201421382">(Jun 19 2020 at 17:49)</a>:</h4>
<p>it worked when I re-did it</p>



<a name="201421384"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approving%20new%20targets/near/201421384" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html#201421384">(Jun 19 2020 at 17:49)</a>:</h4>
<p>no idea what happened</p>



<a name="201489554"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approving%20new%20targets/near/201489554" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> anp <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html#201489554">(Jun 20 2020 at 18:06)</a>:</h4>
<p>catching up, it looks like T-compiler was added as a label after you pinged rfcbot, so it would have needed another ping (i think an edit of the original comment might have done it) to run on  that issue</p>



<a name="201489808"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/approving%20new%20targets/near/201489808" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> anp <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/approving.20new.20targets.html#201489808">(Jun 20 2020 at 18:11)</a>:</h4>
<p>opened <a href="https://github.com/rust-lang/rfcbot-rs/issues/286">https://github.com/rust-lang/rfcbot-rs/issues/286</a></p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>